Create function run_test_and_analyze_failed_logs()

This function calls test suite specified by first parameter
and in case of failure it sends the failed logs to logdetective

Signed-off-by: Petr "Stone" Hracek <[email protected]>

Author: phracek

test.sh

@@ -28,6 +28,32 @@ failed_version() {
   return "$result"
 }
 
+# run_test_and_analyze_failed_logs
+# ------------------------------------------
+# Function calls specific test suite and in case of failure
+# it sends the failed logs to logdetective and prints report
+# generated by logdetective AI
+# Argument: test_run - what kind of test that will be executed. Like 'test/run'
+run_test_and_analyze_failed_logs() {
+  local test_run="$1"
+  set -o pipefail
+  tmp_file=$(mktemp "/tmp/${OS}-${dir}.XXXXXX")
+  VERSION=$dir $test_run 2>&1 | tee "$tmp_file"
+  ret_code=$?
+  set +o pipefail
+  cat "${tmp_file}"
+  if [[ "$ret_code" != "0" ]]; then
+    if [[ "${OS}" == "rhel8" ]] || [[ "${OS}" == "rhel9" ]] || [[ "${OS}" == "rhel10" ]]; then
+      set +e
+      analyze_logs_by_logdetective "$tmp_file"
+      # Let's switch it back
+      set -e
+    fi
+  fi
+  failed_version "$ret_code" "$dir"
+  rm -f "$tmp_file"
+
+}
 # This adds backwards compatibility if only single version needs to be testing
 # In CI we would like to test single version but VERSIONS= means, that nothing is tested
 # make test TARGET=<OS> VERSIONS=<something> ... checks single version for CLI
@@ -51,22 +77,7 @@ for dir in ${VERSIONS}; do
   fi
 
   if [ -n "${TEST_MODE}" ]; then
-    set -o pipefail
-    tmp_file=$(mktemp "/tmp/${OS}-${dir}.XXXXXX")
-    VERSION=$dir test/run 2>&1 | tee "$tmp_file"
-    ret_code=$?
-    set +o pipefail
-    cat "${tmp_file}"
-    if [[ "$ret_code" != "0" ]]; then
-      if [[ "${OS}" == "rhel8" ]] || [[ "${OS}" == "rhel9" ]] || [[ "${OS}" == "rhel10" ]]; then
-        set +e
-        analyze_logs_by_logdetective "$tmp_file"
-        # Let's switch it back
-        set -e
-      fi
-    fi
-    failed_version "$ret_code" "$dir"
-    rm -f "$tmp_file"
+    run_test_and_analyze_failed_logs "test/run"
   fi
 
   if [ -n "${TEST_OPENSHIFT_4}" ]; then
@@ -76,8 +87,7 @@ for dir in ${VERSIONS}; do
       echo "-> .exclude-openshift file exists for version $dir, skipping OpenShift-4 tests."
     else
       if [ -x test/run-openshift-remote-cluster ]; then
-        VERSION=$dir test/run-openshift-remote-cluster
-        failed_version "$?" "$dir"
+        run_test_and_analyze_failed_logs "test/run-openshift-remote-cluster"
       else
         echo "-> Tests for OpenShift 4 are not present. Add run-openshift-remote-cluster script, skipping"
       fi
@@ -87,40 +97,23 @@ for dir in ${VERSIONS}; do
 
   if [ -n "${TEST_UPSTREAM}" ]; then
     if [ -x test/run-upstream ]; then
-      set -o pipefail
-      tmp_file=$(mktemp "/tmp/${OS}-${dir}.XXXXXX")
-      VERSION=$dir test/run-upstream 2>&1 | tee "$tmp_file"
-      ret_code=$?
-      set +o pipefail
-      cat "${tmp_file}"
-      if [[ "$ret_code" != "0" ]]; then
-        if [[ "${OS}" == "rhel8" ]] || [[ "${OS}" == "rhel9" ]] || [[ "${OS}" == "rhel10" ]]; then
-          set +e
-          analyze_logs_by_logdetective "$tmp_file"
-          # Let's switch it back
-          set -e
-        fi
-      fi
-      failed_version "$ret_code" "$dir"
-      rm -f "$tmp_file"
+      run_test_and_analyze_failed_logs "test/run-upstream"
     else
       echo "-> Upstream tests are not present, skipping"
     fi
   fi
 
   if [ -n "${TEST_OPENSHIFT_PYTEST}" ]; then
     if [ -x test/run-openshift-pytest ]; then
-      VERSION=$dir test/run-openshift-pytest
-      failed_version "$?" "$dir"
+      run_test_and_analyze_failed_logs "test/run-openshift-pytest"
     else
       echo "-> OpenShift PyTest tests are not present, skipping"
     fi
   fi
 
   if [ -n "${TEST_PYTEST}" ]; then
     if [ -x test/run-pytest ]; then
-      VERSION=$dir test/run-pytest
-      failed_version "$?" "$dir"
+      run_test_and_analyze_failed_logs "test/run-pytest"
     else
       echo "-> PyTest tests are not present, skipping"
     fi