Skip to content

BUG: include timezone info in datetime_to_str converter #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
+5 −5
Merged

BUG: include timezone info in datetime_to_str converter #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cac347d
BUG: dates have been converted to UTC already, don’t inherit tz
bsipocz Jul 29, 2025
b04ca6b
BUG: keep the timezone info when converting to string
bsipocz Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions yaml2ics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
}


def datetime2utc(date):
def datetime_to_str(date):
if isinstance(date, datetime.datetime):
return datetime.datetime.strftime(date, "%Y%m%dT%H%M%S")
return datetime.datetime.strftime(date, "%Y%m%dT%H%M%S%z")
elif isinstance(date, datetime.date):
return datetime.datetime.strftime(date, "%Y%m%d")
return datetime.datetime.strftime(date, "%Y%m%d%z")


def utcnow():
Expand Down Expand Up @@ -122,11 +122,11 @@ def event_from_yaml(event_yaml: dict, tz: datetime.tzinfo = None) -> ics.Event:
)

if "except_on" in repeat:
exdates = [datetime2utc(rdate) for rdate in repeat["except_on"]]
exdates = [datetime_to_str(rdate) for rdate in repeat["except_on"]]
add_recurrence_property(event, "EXDATE", exdates, tz)

if "also_on" in repeat:
rdates = [datetime2utc(rdate) for rdate in repeat["also_on"]]
rdates = [datetime_to_str(rdate) for rdate in repeat["also_on"]]
add_recurrence_property(event, "RDATE", rdates, tz)

event.dtstamp = utcnow()
Expand Down
Loading