feat: enhance license API with comprehensive metadata and expression parsing #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isasmendiagus
commented
Jun 12, 2025
isasmendiagus
commented
Jun 12, 2025
| // LICENSE REPRESENTATIONS | ||
| // ======================================================================== | ||
|
|
||
| message BasicLicense { |
There was a problem hiding this comment.
Maybe call it License?
| string full_name = 2; | ||
| } | ||
|
|
||
| message License { |
There was a problem hiding this comment.
And here LicenseDetailed
| }; | ||
|
|
||
| // Get detailed metadata for a specific license | ||
| rpc GetDetails(LicenseRequest) returns(DetailsResponse) { |
There was a problem hiding this comment.
This method allow to query only one license. Maybe add another for querying a list of license ids?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced License API to handle complex license expressions and provide comprehensive metadata from multiple authoritative sources.
Example Response
Query:
LicenseService.GetByPurl('pkg:github/example/component'){ "license_statement": "MIT AND GPL-2.0 WITH Classpath-exception-2.0", "licenses": [ { "name": "MIT", "spdx": { "id": "MIT", "name": "MIT License", "is_fsf_libre": true, "exceptions": [] }, "scanoss": { "license_type": "PERMISSIVE", "risk_level": "LOW" } }, { "name": "GPL-2.0 WITH Classpath-exception-2.0", "spdx": { "id": "GPL-2.0", "name": "GNU General Public License v2.0", "exceptions": [ { "id": "Classpath-exception-2.0", "name": "Classpath exception 2.0" } ] }, "osadl": { "copyleft_clause": true, "use_cases": [...] }, "scanoss": { "license_type": "COPYLEFT", "risk_level": "MEDIUM" } } ] }