Add tests for pullRequests.grouping syntax
#3654
Open
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added a commit
to guardian/scala-steward-public-repos
that referenced
this pull request
Jun 13, 2025
rtyley
force-pushed
the
add-tests-to-clarify-pullRequests.grouping-syntax
branch
from
82650b4 to
af9a7e4
Compare
rtyley
added a commit
to guardian/scala-steward-public-repos
that referenced
this pull request
Jun 13, 2025
rtyley
changed the title
pullRequests.grouping syntaxpullRequests.grouping syntax
rtyley
force-pushed
the
add-tests-to-clarify-pullRequests.grouping-syntax
branch
from
af9a7e4 to
942528d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 174 174
Lines 5045 5045
Branches 495 495
=======================================
Hits 4532 4532
Misses 513 513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colleague mentioned to me that some of our
pullRequests.groupingwere not pulling in all the artifacts we were expecting - while looking into this, I realised that I wasn't 100% clear on where wildcards could be used inpullRequests.grouping, so I wrote this test to exercise all the cases that were relevant to us, and see what worked - this may be tested elsewhere to some extent in the Scala Steward codebase, but I think it's helpful to drill into the specific functionality with these new tests onPullRequestUpdateFilter.See also
updates.*&pullRequests.groupingconfig use inconsistent group-&-artifact-id matching expressions #3655