Skip to content

Revert 2 fix bug/fix build android #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Revert 2 fix bug/fix build android #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5b3358
remove ViewPropTypes disappeared
Sotatek-SonNguyen2 Oct 13, 2021
2218fc3
remove requireNativeComponent
Sotatek-SonNguyen2 Oct 13, 2021
bfa8582
fix-bug/fix-build-android: fix build android
hieudo2 Oct 20, 2021
2436592
Update RNPublisherBanner.js
Oct 20, 2021
1d59414
Merge pull request #1 from nocodejapan/fix-bug/fix-build-android
Sotatek-SonNguyen2 Oct 20, 2021
1461925
Update RNAdMobBanner.js
Oct 20, 2021
6d2a28b
Update RNPublisherBanner.js
Oct 20, 2021
6856822
Merge pull request #2 from nocodejapan/fix-bug/fix-build-android
Oct 20, 2021
9d6f5bb
Revert "Fix bug/fix build preview"
Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions RNAdMobBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import { arrayOf, func, string } from 'prop-types';
import React, { Component } from 'react';
import {
findNodeHandle,
requireNativeComponent,
UIManager,
ViewPropTypes,
requireNativeComponent,
} from 'react-native';
import { createErrorFromErrorData } from './utils';

Expand Down Expand Up @@ -62,7 +61,6 @@ class AdMobBanner extends Component {
AdMobBanner.simulatorId = 'SIMULATOR';

AdMobBanner.propTypes = {
...ViewPropTypes,

/**
* AdMob iOS library banner size constants
Expand Down
4 changes: 1 addition & 3 deletions RNPublisherBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import { arrayOf, func, string } from 'prop-types';
import React, { Component } from 'react';
import {
findNodeHandle,
requireNativeComponent,
UIManager,
ViewPropTypes,
requireNativeComponent,
} from 'react-native';
import { createErrorFromErrorData } from './utils';

Expand Down Expand Up @@ -71,7 +70,6 @@ class PublisherBanner extends Component {
PublisherBanner.simulatorId = 'SIMULATOR';

PublisherBanner.propTypes = {
...ViewPropTypes,

/**
* DFP iOS library banner size constants
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ android {

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'com.google.android.gms:play-services-ads:+'
implementation 'com.google.android.gms:play-services-ads:16.0.0'
}