-
Notifications
You must be signed in to change notification settings - Fork 29
Support Palantir Java Format #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The main question is: What should we do? 😄 So, I see a two options:
|
@mkurz WDYT? |
First option in the first commit of this PR, second in second 😄 |
I'm -1 on this. To each their own, but I don't want to voluntarily install software developed by Palantir. |
But formatter is just OSS project that is developed by community and published under APL 2.0 like Sbt itself or Play 🤔 |
Since I can't check every commits, I can only use heuristics like "can I trust this company to not hack into my stuff", and this company literally makes software for military and spy agencies like CIA. |
I think I can extract the core part and split formatters on the plugin side not in settings. I mean
or
@eed3si9n is it ok? WDYT? |
It's marginally better, but if you keep their code in the repo anyone maintaining this plugin would have to run it on their laptop to run tests? |
Yes, it's true. The users of |
Details about Palantir Java Format in the README -> https://github.com/palantir/palantir-java-format