[vmware] Cache images as VM templates #295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemna
force-pushed
the
imagecache-antelope
branch
3 times, most recently
from
7951528 to
d2f9c99
Compare
Scsabiii
reviewed
Nov 19, 2025
cinder/volume/drivers/vmware/vmdk.py
Outdated
|
|
||
| def _can_use_image_cache(self, volume, image_size): | ||
| requested = (volume['metadata'] | ||
| .get(CREATE_PARAM_USE_IMAGE_CACHE, "").lower() |
There was a problem hiding this comment.
I would change this, so the customer does not need to specify anything, and just cache all images that are smaller then 100 GB(can be changed via parameter)
Author
There was a problem hiding this comment.
yah I agree, I don't think we should force customers to put some magic, non openstack metadata in their volumes just to enable our internal feature.
Upon user request, the driver can cache the image as a VM Template
and reuse that to create the volume(s). This feature is useful
when creating many volumes in parallel from the same image.
We're not using the cinder built-in cache functionality because we
need a few extra features:
- the built-in cache doesn't account for shards. The cache entry
will be placed on any backend/shard and could trigger a lot of
slower cross-vc migrations when creating volumes from it.
- the built-in cache doesn't have a periodic task for deleting the
expired cache entries
- we want to cache the images only when the customer requests it
Users can request the image cache feature when creating the volume,
by passing the use_image_cache='true' as a property (metadata).
The feature must be enabled per backend, for example:
```
[vmware]
enable_image_cache = true
```
This will enable the image cache feature for the vmware backend.
The image templates will then be stored in a folder similar to the
volumes folder: OpensStack/Project (vmware_image_cache)/Volumes,
where {backend}_image_cache is used as a project name.
The driver will periodically delete the cached images that are
expired. The expiry time can be controlled via the property
`image_cache_age_seconds` set on the backend configuration.
Only images smaller than the configured `image_cache_max_size_gb`
will be cached.
Change-Id: Id26f61104339e5ccc1db3a6017f159462c8cba37
hemna
force-pushed
the
imagecache-antelope
branch
from
d2f9c99 to
7f30546
Compare
|
Can we also implement the |
Scsabiii
previously approved these changes
Nov 19, 2025
Scsabiii
force-pushed
the
imagecache-antelope
branch
2 times, most recently
from
d6be6b8 to
3201607
Compare
Change-Id: Id91017bc9c934d99bdfcdafe143a1fed66f06d23
Scsabiii
force-pushed
the
imagecache-antelope
branch
from
3201607 to
5a03e6c
Compare
Scsabiii
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon user request, the driver can cache the image as a VM Template and reuse that to create the volume(s). This feature is useful when creating many volumes in parallel from the same image.
We're not using the cinder built-in cache functionality because we need a few extra features:
Users can request the image cache feature when creating the volume, by passing the use_image_cache='true' as a property (metadata).
The feature must be enabled per backend, for example:
This will enable the image cache feature for the vmware backend.
The image templates will then be stored in a folder similar to the volumes folder: OpensStack/Project (vmware_image_cache)/Volumes, where {backend}_image_cache is used as a project name.
The driver will periodically delete the cached images that are expired. The expiry time can be controlled via the property
image_cache_age_secondsset on the backend configuration.Only images smaller than the configured
image_cache_max_size_gbwill be cached.Change-Id: Id26f61104339e5ccc1db3a6017f159462c8cba37