Cleanup package.json #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move approp documentation to seperate md file remove deprecated importmapextras
VoigtS
requested review from
Nuckal777,
SuperSandro2000 and
majewsky
as code owners
majewsky
reviewed
Nov 21, 2024
Co-authored-by: Sandro <[email protected]>
majewsky
approved these changes
Nov 22, 2024
Member
Author
|
I move this to draft for now. It turns out simply removing the parameters is not sufficient. The whole Juno helper depends on them which I need to think about how to handle this properly. |
Member
Author
|
TODO: Clear up projectID and domainID envs and get them from the token instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move approp documentation to seperate md file
remove deprecated importmapextras