Update test output to work with HTSlib Number= PR htslib#1874 #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htslib#1874 changes `bcf_remove_allele_set()` so that it no longer removes format fields with Type=String, Number=G and the only value left is MISSING. This alters the output of a couple of the `bcftools view -a` tests as the `FGS` tag is kept with a MISSING value instead of being removed completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR samtools/htslib#1874 changes
bcf_remove_allele_set()so that it no longer removes format fields with Type=String, Number=G and the only value left is MISSING. This alters the output of a couple of thebcftools view -atests as theFGStag is kept with a MISSING value instead of being removed completely.N.B. To avoid test failures, samtools/htslib#1874 needs to be merged into HTSlib first, then this should go into BCFtools as soon as possible after.