Fixing the decrypting option of keyconv #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message was created from the 'optargs' variable which is only correct if the -s whatever was the last item on the command line.
General security principle, always default to the most secure option. If someone wants to -s /dev/zero the still can of course, but we assume they know what they are doing! Not all non windows platforms have a /dev/random, you can disable it on Linux if you really want to, so we check first.
Now we read from /dev/random by default, this message isn't really that important anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the option to decrypt encrypted Public keys, that were encrypted by vanitygen.