Skip to content

Make tomcat permissions stricter and remove ubuntu user #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make tomcat permissions stricter and remove ubuntu user #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tomcat/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# You need to supply a TOMCAT_VERSION build argument, otherwise the build will fail
ARG TOMCAT_VERSION
FROM tomcat:$TOMCAT_VERSION

Check warning on line 3 in tomcat/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (10) / Dockerize

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG tomcat:$TOMCAT_VERSION results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 3 in tomcat/Dockerfile

View workflow job for this annotation

GitHub Actions / ci (10) / Dockerize

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG tomcat:$TOMCAT_VERSION results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

### Environment Variables need to be set at build time
### TODO: this needs to be done on build ...
Expand Down Expand Up @@ -29,7 +29,8 @@
adduser --disabled-password --ingroup www-data $COMPONENT; \
chown -R $COMPONENT:www-data $CATALINA_HOME /docker/ /usr/local/share/ca-certificates/ $JAVA_HOME/lib/security/cacerts /etc/ssl/certs/ /run/secrets/; \
mkdir /docker/custom-certs/; \
chmod -R 755 $CATALINA_HOME /docker/;
chmod -R 750 $CATALINA_HOME /docker/;

RUN usermod -s /usr/sbin/nologin ubuntu
ONBUILD USER $COMPONENT
ENTRYPOINT ["/docker/tomcat_entrypoint.sh"]