-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Missing debian ip options #68359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perhallgren
wants to merge
2
commits into
saltstack:3006.x
Choose a base branch
from
perhallgren:fix/3006.x/missing-debian-ip-options
base: 3006.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Missing debian ip options #68359
perhallgren
wants to merge
2
commits into
saltstack:3006.x
from
perhallgren:fix/3006.x/missing-debian-ip-options
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
twangboy
previously approved these changes
Oct 1, 2025
This was
linked to
issues
Oct 1, 2025
bee8a26 to
76625fc
Compare
|
twangboy the build failed due to a trailing space. I force-pushed a fix onto the previous commit. Do I need to do anything to re-run the CI? |
twangboy
previously approved these changes
Oct 6, 2025
6fe25f1 to
d108c96
Compare
Tests that all mapped options are also in valid_opts.
d108c96 to
8c61b05
Compare
|
@twangboy looks lke the pipeline is pending approval to run, can you help out? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For debian-ip, not all options get rendered in the final
interfacesfile.The valid_opts list must be a superset of the keys of the optmap map for the mappted options to get rendered.
This commit adds the missing options to the valid_opts list.
What issues does this PR fix or reference?
Fixes #58210 and #57820.
Previous Behavior
Given
/etc/network/interfacesNew Behavior
Given
/etc/network/interfacesMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes