This repository was archived by the owner on Apr 10, 2025. It is now read-only.
feat: upgrade react native to latest version and remove codepush #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledutu2
requested review from
honghoangsts,
baonguyenhsts,
hoangSTS,
huydosgtech,
loc-nguyenthien,
loido,
ThinhKimVo,
ngochuyduong and
hangnguyensaigontech
as code owners
loc-nguyenthien
suggested changes
Apr 4, 2025
|
|
||
| // We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP. | ||
| ndkVersion = "23.1.7779620" | ||
| buildToolsVersion = "35.0.0" |
| rootProject.name = 'RNBaseProject' | ||
| apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) | ||
| include ':app', ':react-native-code-push' |
There was a problem hiding this comment.
Remove codepush
Suggested change
| include ':app', ':react-native-code-push' | |
| include ':app' |
| rootProject.name = 'RNBaseProject' | ||
| apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) | ||
| include ':app', ':react-native-code-push' | ||
| project(':react-native-code-push').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-code-push/android/app') |
| #if DEBUG | ||
| RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index") | ||
| #else | ||
| CodePush.bundleURL() |
There was a problem hiding this comment.
Check this, remove codepush
There was a problem hiding this comment.
Why are we have this file again?
| "react-native": "^0.71.7", | ||
| "react-native-code-push": "^8.0.2", | ||
| "react": "19.0.0", | ||
| "react-native": "0.78.2", | ||
| "react-native-config": "^1.5.1", | ||
| "react-native-device-info": "^10.6.0", | ||
| "react-native-gesture-handler": "^2.8.0", |
There was a problem hiding this comment.
Consider upgrade this too
| "react-native-progress": "^5.0.0", | ||
| "react-native-safe-area-context": "^4.6.3", | ||
| "react-native-reanimated": "^3.0.2", |
There was a problem hiding this comment.
Consider upgrade this too
| "build": "bash ./scripts/build-app.sh" | ||
| }, | ||
| "dependencies": { | ||
| "@gorhom/bottom-sheet": "^4.4.6", | ||
| "@react-native-async-storage/async-storage": "^1.18.1", | ||
| "@react-navigation/native": "^6.1.6", | ||
| "@react-navigation/native-stack": "^6.9.12", |
There was a problem hiding this comment.
Consider upgrade this too (if possible) to v7
There was a problem hiding this comment.
i think i will upgrade it in another PR
|
Lỡ mấy bữa nữa mình gắn lại Codepush thì sao nhỉ |
|
thì lúc đó gắn vào lại a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.