Skip to content

resolve 'undefined l' error #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

resolve 'undefined l' error #2

wants to merge 3 commits into from

Conversation

priyankchheda
Copy link

resolve "undefined: l" error.
sample input of 1 million records for benchmarking.

sagivo
sagivo requested changes Jan 4, 2019
View reviewed changes
Copy link
Owner

@sagivo sagivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify it and leave the extra arguments as the focus should be on the algorithm and not on oop design for this example.

@priyankchheda
Copy link
Author

I removed those extra input validation test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagivo sagivo sagivo requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@priyankchheda @sagivo