Improve error checks in Mimedir parser #727
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mimedir parser has a general flaw which is it simply ignores tokens it doesn't recognize.
As an example, the following property is invalid according to the specifications, and should be rejected by the parser.
FN;P1=value1; P2=value2:value
The problem is a whitespace in front of parameter name P2, which is not allowed according to the grammar described here . However, the current Mimedir parser do accept the line and furthermore misinterprets it to be on this format:
FN;P1=value1,value2:value
This pull request solves this specific problem by introducing the possibility to look back on the previous token parsed. Maybe it can be further improved by adding more checks. However a more general solution should possibly be preferred, I guess a complete rewrite of the parser could be the best solution.