Fix variable scope #721
Open
Fix variable scope #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
=========================================
Coverage 98.76% 98.76%
Complexity 1875 1875
=========================================
Files 71 71
Lines 5345 5345
=========================================
Hits 5279 5279
Misses 66 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method Broker::parseEventForOrganizer is long and might not be that easy to read and understand. Near the end of the method, the variable
$attendeewhich is used in major parts of the method as an iterator pointer, is suddenly re-used as an iterator pointer in another context. Even though this does not lead to any problems right now, it could be a problem in the future, i.e. when someone wants to extend the function. Therefore, I propose to rename the inner$attendeeiterator variable.