Skip to content

Conversation

@thatnerdjosh
Copy link
Contributor

@thatnerdjosh thatnerdjosh commented Jan 29, 2024

@thatnerdjosh thatnerdjosh force-pushed the support/update_dockerfiles branch from 3f5f272 to 3913aba Compare January 29, 2024 11:01

[*]
insert_final_newline = true
end_of_line = lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our line endings are set to platform native in git configuration.

Copy link
Contributor Author

@thatnerdjosh thatnerdjosh Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - the issue I was having is most files were checked in LF, but there were some files which were CRLF in the repo, which caused the branch to be dirty immediately on checkout. Do you have a solution for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they should be in LF in the repo, so committing the LF files is the correct fix for that. Just local storage should be in native.

See https://github.com/ryzom/ryzomcore/blob/core4/.gitattributes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those defective files might've been committed before the .gitattributes was cleaned up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing - I'll remove this editorconfig change then as it's not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants