-
-
Notifications
You must be signed in to change notification settings - Fork 29
Fix VFE issue syncing CommandWithCompBuilding stuffs & Add compat for EccentricTech.DefenseGrid by Aelanna #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Should fix VFE-Faction Machanoid_ FishTrapper being able to set products The issue is that Command_SetItemsToSpawn is actualing using a ThingComp as param instead of Thing, witch can't be synced as Thing. Added function for command with comp_building.
Something is wrong here.
|
remains there, actually the original method SyncCommandWithBuilding was referenced 3 times, here one of them makes error, but the other 2 are fine, so I created a new method for this and remains the old SyncCommandWithBuilding there for these methods. |
Looks like the field called I've added a review on the file, as I'm not sure about the Also, could you check if the SyncWorker you've added be used to replace the one for The sync worker I'm talking about: Multiplayer-Compatibility/Source/Mods/VanillaExpandedFramework.cs Lines 693 to 699 in 0ae5497
|
Yeah, didn't mean to add that using, sry. |
It works, but I'm not gonna push it now , as there maybe more things I can do here :P |
FORGOT to create branch omg. p.s. Have to use reference or there could be a bunch of Reflections :( |
Seems this mod got visualeffect class in another dll. Would fix those with Rand.push/pop later. |
Please separate them by feature. |
This should fix null pointer error when select products for FishTrapper from VFE-Faction Machanoid.
The function should sync 'building' as ThingComp instead of Thing, which causes null pointer.