-
-
Notifications
You must be signed in to change notification settings - Fork 183
uefi-raw: Add bindings for most HII protocols #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
89651fd to
96848f4
Compare
96848f4 to
6b89cae
Compare
3f187e7 to
aea4371
Compare
|
I've added the Form Browser and Popup protocols for completion, since I know I'll need the form browser. All HII protocols should now have bindings, except:
|
aea4371 to
e141477
Compare
Add bindings for the following protocols: - HiiFont (EFI_HII_FONT_PROTOCOL) - HiiFontEx (EFI_HII_FONT_EX_PROTOCOL) - HiiString (EFI_HII_STRING_PROTOCOL) - HiiImage (EFI_HII_IMAGE_PROTOCOL) - HiiImageEx (EFI_HII_IMAGE_EX_PROTOCOL) - HiiPopup (EFI_HII_POPUP_PROTOCOL) - FormBrowser2 (EFI_FORM_BROWSER2_PROTOCOL) Ref: UEFI 2.11: 34 HII Protocols Ref: UEFI 2.11: 35 HII Configuration Processing and Browser Protocol Signed-off-by: Tim Crawford <[email protected]>
e141477 to
810f778
Compare
phip1611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you point me to any higher-level real world usage of these protocols? Would love to see a real-world demo
|
System76 has several UEFI modules currently using In this case of HII, we replace edk2's Form Display Engine (FDE) Protocol ( (Examples of what the UI looks like can be seen in e.g.: system76/firmware-setup#53) The Internal Forms Representation (IFR) bindings still need to be added in a follow up for actually processing forms data for rendering. And the actual declaration of the forms themselves is still done from edk2 modules using its Visual Forms Representation (VFR) language. |
Add bindings for the following protocols:
EFI_HII_FONT_PROTOCOL)EFI_HII_FONT_EX_PROTOCOL)EFI_HII_STRING_PROTOCOL)EFI_HII_IMAGE_PROTOCOL)EFI_HII_IMAGE_EX_PROTOCOL)EFI_HII_POPUP_PROTOCOL)EFI_FORM_BROWSER2_PROTOCOL)Ref: UEFI 2.11: 34 HII Protocols
Ref: UEFI 2.11: 35 HII Configuration Processing and Browser Protocol
TODO
ImageOutputHiiFontExProtocol.get_glyph_infoAdd HII package definitions for database integration (Section 33.3)?Checklist