Scope down promote_release IAM role S3 permissions #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the promote_release IAM role.
| Action = [ | ||
| "s3:GetObjectAcl", | ||
| "s3:GetObject", | ||
| "s3:DeleteObject", |
There was a problem hiding this comment.
Hm, I actually am not sure we need delete permissions on the CI artifacts bucket -- I think we should only read from that bucket. Are you aware of some deletion in our scripts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my limited understanding of the promote_release role, it only needs to read and delete objects from the artifacts bucket and doesn't need to write anything there. This change removes s3:PutObject and s3:PutObjectAcl permissions on the artifacts bucket from the promote_release role. I have tested with
terraform validate(with some local mods to, e.g. bucket names) but I am not able to validate this any further. Any feedback would be welcome.