Skip to content

Improve error message when perf-config.json is not found #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Improve error message when perf-config.json is not found #2142

merged 1 commit into from
May 28, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 28, 2025

Before it was quite hard to figure out what is happening.

@Kobzol
Improve error message when perf-config.json is not found
62ceed9 
Before it was quite hard to figure out what is happening.
lqd
lqd approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar issue when there remained some folders of the benchmarks that were deleted; the collector was just saying File not found 😓

@lqd lqd merged commit 9cae27a into rust-lang:master May 28, 2025
11 checks passed
@Kobzol Kobzol deleted the build-script-error branch May 28, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @lqd