Skip to content

Add unicode-normalization-0.1.24 #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Apr 30, 2025

Compile times got slightly faster:

Screenshot from 2025-04-30 13-14-07

because the number of lines of Rust code dropped from 27,495 to 24,351. It still has huge tables and match statements, though, which is the point of the benchmark.

Related issue: #2024

@nnethercote nnethercote requested a review from Kobzol April 30, 2025 03:22
@nnethercote
Copy link
Contributor Author

Part of #2024.

@@ -1,5 +1,5 @@
target
Cargo.lock
#Cargo.lock
Copy link
Contributor

@Kobzol Kobzol Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed, we can just force add the file to our git index and it will be tracked from then on. But no harm in this either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, from the how-to-update docs I wasn't sure if it was necessary or if -f was enough.

@Kobzol Kobzol added the benchmark-update PR that updates the benchmark set. label Apr 30, 2025
@Kobzol Kobzol merged commit 984c61e into rust-lang:master Apr 30, 2025
11 checks passed
@Kobzol Kobzol mentioned this pull request Apr 30, 2025
41 tasks
@nnethercote nnethercote deleted the update-unicode-normalization branch April 30, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark-update PR that updates the benchmark set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants