Skip to content

Conversation

@hkBst
Copy link
Member

@hkBst hkBst commented Oct 31, 2025

This cleans up the dangling_pointers_from_locals lint.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2025

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Urgau
Copy link
Member

Urgau commented Oct 31, 2025

r? Urgau

@rustbot rustbot assigned Urgau and unassigned eholk Oct 31, 2025
@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2025
@Urgau
Copy link
Member

Urgau commented Nov 1, 2025

@rustbot author

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2025
@rust-cloud-vms rust-cloud-vms bot force-pushed the dangling-ptr-lint-1 branch from ce22bdc to 0bd6a03 Compare November 1, 2025 15:15
@hkBst
Copy link
Member Author

hkBst commented Nov 1, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2025
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me. Happy to approve/merge, unless you want to take a look at dangling_pointers_from_temporaries lint.

View changes since this review

@hkBst
Copy link
Member Author

hkBst commented Nov 1, 2025

@Urgau I don't know when I'll get to ..._temporaries so if you're willing to approve this, that would be best.

@Urgau
Copy link
Member

Urgau commented Nov 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit 0bd6a03 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 2, 2025
dangling ptr lint cleanup

This cleans up the dangling_pointers_from_locals lint.
bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 12 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #147642 (Miscellaneous const-generics-related fixes)
 - #147806 (Ignore test-dashboard related files)
 - #147947 (Implement `strip_circumfix` lib feature)
 - #148194 (compiletest: Remove `cleanup_debug_info_options`)
 - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts)
 - #148247 (Remove two special cases from reachable_non_generics)
 - #148348 (dangling ptr lint cleanup)
 - #148357 (temporary-lifetime-extension.rs test works in all editions)
 - #148362 (docs: makes a note about possible building  `rustc 1.91.0 + host tools` for win7)
 - #148367 (Use --print host-tuple to get the host)
 - #148374 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 2, 2025
dangling ptr lint cleanup

This cleans up the dangling_pointers_from_locals lint.
@bors
Copy link
Collaborator

bors commented Nov 2, 2025

⌛ Testing commit 0bd6a03 with merge 5668968...

bors added a commit that referenced this pull request Nov 2, 2025
dangling ptr lint cleanup

This cleans up the dangling_pointers_from_locals lint.
bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 9 pull requests

Successful merges:

 - #147137 (Mention crate being analyzed in query description)
 - #147155 (arm-linux.md: various fixes/improvements)
 - #147642 (Miscellaneous const-generics-related fixes)
 - #147806 (Ignore test-dashboard related files)
 - #147947 (Implement `strip_circumfix` lib feature)
 - #148346 (Change cfg_trace, cfg_attr_trace symbol values)
 - #148348 (dangling ptr lint cleanup)
 - #148393 (Remove `tests/run-make/fmt-write-bloat/`)
 - #148400 (Better warning message for crate type unsupported by codegen backend)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e62b652 into rust-lang:master Nov 2, 2025
11 of 12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 2, 2025
rust-timer added a commit that referenced this pull request Nov 2, 2025
Rollup merge of #148348 - hkBst:dangling-ptr-lint-1, r=Urgau

dangling ptr lint cleanup

This cleans up the dangling_pointers_from_locals lint.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 3, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#147137 (Mention crate being analyzed in query description)
 - rust-lang/rust#147155 (arm-linux.md: various fixes/improvements)
 - rust-lang/rust#147642 (Miscellaneous const-generics-related fixes)
 - rust-lang/rust#147806 (Ignore test-dashboard related files)
 - rust-lang/rust#147947 (Implement `strip_circumfix` lib feature)
 - rust-lang/rust#148346 (Change cfg_trace, cfg_attr_trace symbol values)
 - rust-lang/rust#148348 (dangling ptr lint cleanup)
 - rust-lang/rust#148393 (Remove `tests/run-make/fmt-write-bloat/`)
 - rust-lang/rust#148400 (Better warning message for crate type unsupported by codegen backend)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants