Skip to content

Conversation

@moatom
Copy link
Contributor

@moatom moatom commented Oct 28, 2025

Fix #140238

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@moatom moatom force-pushed the stabilize-proc-macro branch from 114e740 to 02f04b0 Compare October 30, 2025 14:12
@rust-log-analyzer

This comment has been minimized.

@moatom moatom force-pushed the stabilize-proc-macro branch from 02f04b0 to 0e341e2 Compare October 30, 2025 15:13
@moatom moatom changed the title WIP: Fix parseing in proc_macro::quote Fix parsing in proc_macro::quote Oct 30, 2025
@moatom moatom marked this pull request as ready for review October 30, 2025 15:14
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@moatom
Copy link
Contributor Author

moatom commented Oct 30, 2025

r? @tgross35

@rustbot rustbot assigned tgross35 and unassigned petrochenkov Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@moatom moatom changed the title Fix parsing in proc_macro::quote Fix parsing logic in proc_macro::quote Oct 30, 2025
@moatom moatom force-pushed the stabilize-proc-macro branch from 0e341e2 to 8dc03cd Compare October 30, 2025 15:23
@moatom moatom force-pushed the stabilize-proc-macro branch from 8dc03cd to 36c13e9 Compare October 30, 2025 15:27
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [ui] tests/ui/proc-macro/quote/basic.rs stdout ----

error: auxiliary build of /checkout/tests/ui/proc-macro/quote/auxiliary/basic.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/proc-macro/quote/auxiliary/basic.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/proc-macro/quote/basic/auxiliary" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "proc-macro" "--extern" "proc_macro" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/proc-macro/quote/basic/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0425]: cannot find value `j` in this scope
##[error]  --> /checkout/tests/ui/proc-macro/quote/auxiliary/basic.rs:66:35
   |
LL |     let tokens = quote!($$ j $($$ j $iter)*);
   |                                   ^ help: a unit struct with a similar name exists: `X`
...
LL | struct X;
   | --------- similarly named unit struct `X` defined here

error[E0282]: type annotations needed
##[error]  --> /checkout/tests/ui/proc-macro/quote/auxiliary/basic.rs:66:35
   |
LL |     let tokens = quote!($$ j $($$ j $iter)*);
   |                                   ^ cannot infer type

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0282, E0425.
For more information about an error, try `rustc --explain E0282`.

@tgross35
Copy link
Contributor

David knows this much better than I do

r? @dtolnay

@rustbot rustbot assigned dtolnay and unassigned tgross35 Oct 30, 2025
@moatom
Copy link
Contributor Author

moatom commented Oct 31, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 31, 2025

@moatom: 🔑 Insufficient privileges: Not in reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for repetition to proc_macro::quote

8 participants