Skip to content

Conversation

@lqd
Copy link
Member

@lqd lqd commented Sep 29, 2025

Some of the captured regions are not considered live anywhere due to this liveness unification of outlives regions for opaque type captures. Check what relies on it on crater.

r? ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2025
@lqd

This comment was marked as outdated.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 29, 2025
crater: check impact of ignoring outlived regions in alias liveness
@rust-log-analyzer

This comment was marked as outdated.

@lqd lqd force-pushed the crater-liveness-captures branch from 25785bb to 870c022 Compare September 29, 2025 12:58
@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@lqd lqd force-pushed the crater-liveness-captures branch from 870c022 to fbd386d Compare September 29, 2025 13:35
@rust-log-analyzer

This comment has been minimized.

@lqd lqd force-pushed the crater-liveness-captures branch from fbd386d to 2fb50a2 Compare September 29, 2025 15:18
@rustbot rustbot added the T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. label Sep 29, 2025
@rust-log-analyzer

This comment has been minimized.

@lqd

This comment was marked as outdated.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 29, 2025
crater: check impact of ignoring outlived regions in alias liveness
@rust-bors

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@lqd lqd force-pushed the crater-liveness-captures branch from 2fb50a2 to b7cf2f4 Compare October 20, 2025 18:10
@lqd

This comment was marked as outdated.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 20, 2025
crater: check impact of ignoring outlived regions in alias liveness
@rust-bors
Copy link

rust-bors bot commented Oct 20, 2025

☀️ Try build successful (CI)
Build commit: 186bb41 (186bb410400c73a03073a8a201cd922634d46d23, parent: bd4a8004c2f3b73795cb4c03bf8e7634e4d89677)

@bors
Copy link
Collaborator

bors commented Oct 22, 2025

☔ The latest upstream changes (presumably #147954) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants