Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Aug 30, 2025

Fixes #146015

With a patch applied to count the number of unifications, and running the query Option<T>, (T -> U) -> Option<U>

before: performed unifyFunctionType on 17484 functions
after: performed unifyFunctionType on 3055 functions

preview:
https://notriddle.com/rustdoc-html-demo-12/polarity/doc/std/index.html
https://notriddle.com/rustdoc-html-demo-12/polarity/compiler-doc/rustc_hir/index.html

With a patch applied to count the number of unifications,
and running the query `Option<T>, (T -> U) -> Option<U>`

before: performed unifyFunctionType on 17484 functions
after: performed unifyFunctionType on 3055 functions
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

📌 Commit 6ef0bfd has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2025
@klensy
Copy link
Contributor

klensy commented Aug 31, 2025

Maybe don't rollup, in case if it hits rustdoc perf?

@GuillaumeGomez
Copy link
Member

Fair point.

@bors rollup-

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

⌛ Testing commit 6ef0bfd with merge 07d246f...

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 07d246f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2025
@bors bors merged commit 07d246f into rust-lang:master Aug 31, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 31, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f73bcd5 (parent) -> 07d246f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 07d246fc6dc227903da2955b38a59e060539a485 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1356.8s -> 1572.6s (15.9%)
  2. dist-aarch64-msvc: 6198.3s -> 5220.4s (-15.8%)
  3. dist-x86_64-apple: 6446.9s -> 7385.0s (14.5%)
  4. aarch64-apple: 5227.9s -> 5729.2s (9.6%)
  5. dist-aarch64-linux: 5712.7s -> 6204.9s (8.6%)
  6. aarch64-gnu-llvm-19-1: 3387.2s -> 3665.0s (8.2%)
  7. dist-apple-various: 3214.0s -> 3473.3s (8.1%)
  8. dist-android: 1628.2s -> 1529.7s (-6.0%)
  9. dist-various-1: 4292.2s -> 4034.6s (-6.0%)
  10. aarch64-msvc-1: 7318.6s -> 6921.4s (-5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@notriddle notriddle deleted the polarity branch September 1, 2025 00:39
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (07d246f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.2%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.1%, 0.2%] 2

Max RSS (memory usage)

Results (primary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.9% [-0.6%, 2.3%] 2

Cycles

Results (primary -2.2%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.6% [4.6%, 4.6%] 1
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.46s -> 468.707s (0.05%)
Artifact size: 388.57 MiB -> 388.59 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-search Area: Rustdoc's search feature merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc search in std for complex signature is significantly slower
7 participants