Skip to content

Use move_file for rename in tracing #146036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

Use move_file for rename in tracing #146036

merged 1 commit into from
Aug 31, 2025
+5 −1

Conversation

Mark-Simulacrum
Copy link
Member

This avoids panicking when the source and destination are on different filesystems.

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 30, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Use move_file for rename in tracing
2dc5752 
This avoids panicking when the source and destinations are on different
filesystems.
@Kobzol
Copy link
Member

Kobzol commented Aug 30, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 30, 2025

📌 Commit 2dc5752 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025
@tgross35 tgross35 mentioned this pull request Aug 30, 2025
Merged
bors added a commit that referenced this pull request Aug 30, 2025
@bors
Auto merge of #146043 - tgross35:rollup-hdumq5v, r=tgross35
cd60c60 
Rollup of 4 pull requests

Successful merges:

 - #144964 (std: clarify `OpenOptions` error for create without write access)
 - #146030 (Fix `sys::process::windows::tests::test_thread_handle` spurious failure)
 - #146035 (Update `browser-ui-test` version to `0.21.3`)
 - #146036 (Use move_file for rename in tracing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7185ec6 into rust-lang:master Aug 31, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Aug 31, 2025
@rust-timer
Unrolled build for #146036
d3e30a1 
Rollup merge of #146036 - Mark-Simulacrum:rust-1, r=Kobzol

Use move_file for rename in tracing

This avoids panicking when the source and destination are on different filesystems.
@rustbot rustbot added this to the 1.91.0 milestone Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @rustbot @rust-log-analyzer @Kobzol @bors @jieyouxu