Added support for creating constant Rvalues backed by different intiger sizes. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/jit/ChangeLog: * jit-playback.cc (add_error, add_error_va): Send DK_ERROR to add_error_va. (add_diagnostic): Call add_diagnostic instead of add_error. * jit-recording.cc (DEFINE_DIAGNOSTIC_KIND): New define. (recording::context::add_diagnostic): New function. (recording::context::add_error): Send DK_ERROR to add_error_va. (recording::context::add_error_va): New parameter diagnostic_kind. * jit-recording.h (add_diagnostic): New function. (add_error_va): New parameter diagnostic_kind. * libgccjit.cc (jit_error): Send DK_ERROR to add_error_va. gcc/testsuite/ChangeLog: * jit.dg/test-error-array-bounds.c: Fix test.
Including: 1. field 2. function 3. rvalue
Fix _Float16 and __float128 support for jit. Add _Float32 and _Float64 support for jit Add Float32 and Float54, update test-types.c
Update path: disable 128 bit integers for testing purposes Target info extended with supported target dependent types update patches Replace unordered_map with unordered_set update patches
For gcc_jit_type_is_float() add unit tests and function description Rename gcc_jit_type_is_float to gcc_jit_type_is_floating improve description Remove unecessary spaces
Related to PR d/110516 but for libgccjit. 2024-01-03 Martin Rodriguez Reboredo <[email protected]> gcc/jit/ * jit-playback.cc: Append TREE_THIS_VOLATILE and TREE_SIDE_EFFECTS to a dereference if underlying type is volatile. Signed-off-by: Martin Rodriguez Reboredo <[email protected]>
gcc/jit/ChangeLog: * jit-recording.h: Remove memento_of_get_const::accepts_writes_from, memento_of_get_type::is_same_type_as: new method. gcc/testsuite/ChangeLog: * jit.dg/all-non-failing-tests.h: Add test-const-pointer-argument.c. * jit.dg/test-const-pointer-argument.c: New test.
This issue happened when compiling rustc with rustc_codegen_gcc, more specifically when compiling its rustc_parse crate. gcc/jit/ PR target/105827 * dummy-frontend.cc: Fix lang_tree_node. * jit-common.h: New function (jit_tree_chain_next) used by lang_tree_node.
antoyo
reviewed
Jul 6, 2025
| @@ -2058,7 +2087,20 @@ gcc_jit_context_new_rvalue_from_long (gcc_jit_context *ctxt, | |||
| return ((gcc_jit_rvalue *)ctxt | |||
| ->new_rvalue_from_const <long> (numeric_type, value)); | |||
| } | |||
| #ifdef __SIZEOF_INT128__ | |||
There was a problem hiding this comment.
I believe the way we should handle the case where 128-bit integers are not supported is by adding an error and returning NULL: so the function would still be defined on targets that don't support them.
| @@ -2111,6 +2153,18 @@ gcc_jit_context_new_rvalue_from_double (gcc_jit_context *ctxt, | |||
| return ((gcc_jit_rvalue *)ctxt | |||
| ->new_rvalue_from_const <double> (numeric_type, value)); | |||
| } | |||
| gcc_jit_rvalue * | |||
There was a problem hiding this comment.
Suggested change
| gcc_jit_rvalue * | |
| gcc_jit_rvalue * |
| @@ -373,3 +373,10 @@ LIBGCCJIT_ABI_42 { | |||
| global: | |||
| gcc_jit_lvalue_add_attribute; | |||
| } LIBGCCJIT_ABI_41; | |||
| LIBGCCJIT_ABI_43 { | |||
There was a problem hiding this comment.
Suggested change
| LIBGCCJIT_ABI_43 { | |
| LIBGCCJIT_ABI_43 { |
antoyo
force-pushed
the
master
branch
2 times, most recently
from
2ae4b0e to
4a8c8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
gcc_jit_context_new_rvalue_from_int128,gcc_jit_context_new_rvalue_from_char,gcc_jit_context_new_rvalue_from_shortandgcc_jit_context_new_rvalue_from_float.This should hopefully allow us to create constant 128 bit ints more easily. The other functions are there for potential memory savings - rvalues backed by char's / shorts / floats instead of the larger types could be a bit smaller than their larger counterparts.