Extract views module into crates_io_api_types crate
#12137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
Moves API response serialization types into dedicated workspace crate: - `src/views.rs` → `crates/crates_io_api_types/src/lib.rs` - `src/views/krate_publish.rs` → `crates/crates_io_api_types/src/krate_publish.rs` - `src/external_urls.rs` → `crates/crates_io_api_types/src/external_urls.rs` Updates `src/lib.rs` to re-export the new crate as `views` for backward compatibility, maintaining existing imports throughout the codebase. Uses `sentry-core` instead of `sentry` for library-appropriate error reporting in the `EncodableCrate::from()` method.
Turbo87
force-pushed
the
api-types-crate
branch
from
d7c171f to
c3a5e7b
Compare
Moves `GitHubConfig` and `NewGitHubConfig` from controller-specific types into a dedicated `trustpub` module in the `crates_io_api_types` crate. These types represent the API request/response models for GitHub Actions trusted publishing configuration, distinct from the database models in `crates_io_database::models::trustpub`.
Moves `ReleaseTracks`, `ReleaseTrackName`, and `ReleaseTrackDetails` from `controllers/krate/versions.rs` into a dedicated `release_tracks` module in the `crates_io_api_types` crate. These types represent version release tracking metadata used in the crate versions API endpoint when `?include=release_tracks` is specified. Unit tests for the release tracking logic are also moved to the new module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves API response serialization types into dedicated workspace crate:
src/views.rs→crates/crates_io_api_types/src/lib.rssrc/views/krate_publish.rs→crates/crates_io_api_types/src/krate_publish.rssrc/external_urls.rs→crates/crates_io_api_types/src/external_urls.rsUpdates
src/lib.rsto re-export the new crate asviewsfor backward compatibility, maintaining existing imports throughout the codebase.Uses
sentry-coreinstead ofsentryfor library-appropriate error reporting in theEncodableCrate::from()method.This will allow us to depend on these types from a future test utils crate, without having to pull in the full
crates_iocrate as a dependency.