Skip to content

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Aug 30, 2025

No description provided.

"build": "ember build --environment=production && node ./script/precompress-assets.mjs",
"build": "vite build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep the precompress-assets.mjs call 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea there is going to be loads that needs fixing on this branch, and a bunch of stuff like this was automatically changed with the codemod.

For this specific thing... shouldn't that work be done with a rollup/vite plugin rather than a "post build script" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like this: https://www.npmjs.com/package/rollup-plugin-gzip (this was literally the first result when searching so I'm not actually proposing this explicitly)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, but this worked well enough and we only need it for the production deployment so spending more time on the investigation wasn't worth it 😉

@Turbo87 Turbo87 changed the title Vite Migrate frontend builds from webpack to Vite Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants