refactor: Define cargo script's target-dir using build-dir templating #16073
+91
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-configuration
weihanglo
reviewed
Oct 8, 2025
| Definition::Path(p) | Definition::Cli(Some(p)) => p.display().fmt(f), | ||
| Definition::Environment(key) => write!(f, "environment variable `{}`", key), | ||
| Definition::Cli(None) => write!(f, "--config cli option"), | ||
| Definition::BuiltIn => write!(f, "defaula"), |
There was a problem hiding this comment.
Suggested change
| Definition::BuiltIn => write!(f, "defaula"), | |
| Definition::BuiltIn => write!(f, "default"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
build-dirs templating was modeled off of thetarget-dirfor cargo scripts but the root dir and hashing are currently duplicated. This consolidates the logic by defining the cargo scripttarget-diras{cargo-cache-home}/target/{workspace-path-hash}.This also serves as preparation for splitting cargo scripts
build-dirandtarget-dir.How to test and review this PR?