Skip to content

Conversation

AndyGauge
Copy link
Contributor

fixes #ISSUE_ID

🎉 Hi and welcome! Please read the text below and remove it - Thank you! 🎉

No worries if anything in these lists is unclear. Just submit the PR and ask away! 👍


Things to check before submitting a PR

  • the tests are passing locally with cargo xtask test all
  • commits are squashed into one and rebased to latest master
  • PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge
    • if issue does not exist consider creating it or remove the clause
  • non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
  • links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
  • example has standard error handling
  • code identifiers in description are in hyperlinked backticks
[`Entry::unpack`]: https://docs.rs/tar/*/tar/struct.Entry.html#method.unpack

Things to do after submitting PR

  • check if CI is happy with your PR

Thank you for reading, you may now delete this text! Thank you! 😄

else
echo "❌ Some tests failed. Check the logs above for details."
exit 1
echo "⚠️ Tests are not required to pass - continuing workflow."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, what the purpose of this job was over just failing the test step.

Looking at the output, you'll still see that the job fails due to the cargo_test step failing.

Is this perhaps a translation from the previous (TravisCI?) workflow or something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to get the ci step optional, but it just turns out that I don't have the same permissions that I had before August 9th. I've raised on Zulip but I'm not sure how to maintain the cookbook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this repo is setup to not allow merges when CI fails and you're not an admin of this repo?

If you want to turn that off for this step, then:
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstepscontinue-on-error

The step will still run and be marked as failed, but it won't cause the job to fail.

@AndyGauge
Copy link
Contributor Author

I needed to accept an invitation. I also fixed the failing test then deployed master

@AndyGauge AndyGauge closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants