feat: Arc and get_mut public method #609
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgued
requested changes
Sep 17, 2025
src/pool/arc.rs
Outdated
|
|
||
| /// Returns the number of strong (`Arc`) pointers to this allocation | ||
| pub fn strong_count(this: &Self) -> usize { | ||
| this.inner().strong.load(Ordering::SeqCst) |
There was a problem hiding this comment.
Why SeqCst and not Relaxed ? This is a public API that has no use besides hinting.
Yeah you're right I will add those methods then! (FYI, I needed these methods, this is why I forked, but indeed it's not complete) |
Hennzau
changed the title
Hennzau
force-pushed
the
arc-get-mut
branch
from
bbff5bf to
9aac2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I don't really know why the public API did not provide those functions before so I added them.
Please tell me if I'm wrong and we can't do that like that