feat: handle empty-body functions in smir.json.
#753
+70
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevengre
requested review from
JuanCoRo,
dkcumming,
jberthold and
tothtamas28
and removed request for
jberthold
3 tasks
|
Is this a duplicate of #677 ? |
I think it does the minimum necessary to avoid crashing on these things in input data (allocs) but does not model the data in any way. |
jberthold
reviewed
Oct 20, 2025
kmir/src/kmir/alloc.py
Outdated
Comment on lines
9
to
12
| if TYPE_CHECKING: | ||
| from typing import Any | ||
| # No conditional typing-only imports needed currently | ||
| pass |
There was a problem hiding this comment.
Maybe this can be deleted then?
If this PR merged, I can modify this one to avoid duplicity. |
Stevengre
force-pushed
the
jh/quick-alloc
branch
from
f535d86 to
f8cf2c4
Compare
Stevengre
force-pushed
the
jh/quick-alloc
branch
from
365cc1f to
b5a7b38
Compare
Stevengre
changed the title
smir.json.
|
By logging the empty-body functions after reducing, we know that these functions wouldn't effect the result of the current spl-token verification (at least with current spec). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.