feat(handler): add support for processing and uploading gif videos to S3 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to handle gif video outputs from ComfyUI nodes, including uploading to S3 bucket and cleaning up local files. The implementation follows the same pattern as image handling but with video-specific content type handling.
Split the output_data list into separate lists for images and videos to improve data organization and clarity. This allows for better handling of different media types in the final result. Update the final result structure to include separate "images" and "videos" fields when present, and modify the completion log message to reflect both media types.
The error messages and status field were only referencing images when checking for empty output data. This change updates them to explicitly mention both images and videos to accurately reflect the possible output types and avoid confusion.
The handler function was not including an empty "videos" array in the final_result when no images or videos were processed, which could cause issues with clients expecting this field. This change ensures consistent response structure by initializing the field similar to how "images" is handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to handle gif video outputs from ComfyUI nodes, including uploading to S3 bucket and cleaning up local files. The implementation follows the same pattern as image handling but with video-specific content type handling.
Motivation
User Demand: Support animated outputs (e.g., GIFs/MP4s) from video-generation nodes (e.g., AnimateDiff, GIF-compatible savers).
Scalability: Videos are larger than images and require dedicated S3 handling (e.g., multipart uploads for big files).
Maintenance: Unify media-handling logic (images + videos) to reduce tech debt.