Add ignore_existing argument to org_create_assignment #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the Github API causes assignment creation to fail before all assignments have been created. I thought it would be nice to be able to re-run the same `org_create_assignment` command to pick up where assignment creation left off, so I added the option to run this function even if some of the requested repositories already exist. There may be reasons why this is a bad idea that I am just not aware of. Don't hesitate to reject this pull request if so.
|
This seems like a reasonable change - I'll need to test it and see if I can find any edge cases but nothing jump out at me right away. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Github API causes assignment creation to fail before all assignments have been created. I thought it would be nice to be able to re-run the same
org_create_assignmentcommand to pick up where assignment creation left off, so I added the option to run this function even if some of the requested repositories already exist.There may be reasons why this is a bad idea that I am just not aware of. Don't hesitate to reject this pull request if so.