avm2: Introduce ParametersExt and use it inside bitmapdata #9930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bale001
reviewed
Mar 8, 2023
|
Does this PR obsolete/supersede #7895? |
|
I'd say no. That PR is on hold until everyone can agree on the design, and I think makes a nicer end goal, but this works for today. |
Aaron1011
approved these changes
Mar 13, 2023
adrian17
approved these changes
Mar 13, 2023
| Value::Null | Value::Undefined => None, | ||
| Value::Object(o) => Some(o), | ||
| primitive => Some( | ||
| PrimitiveObject::from_primitive(primitive, activation) |
There was a problem hiding this comment.
in most places we don't actually expect a primitive (matrix, color_transform, etc), so I'd consider making it a default? (just documenting it well).
On that note, I'd also add get_value(idx) just for a consistent api.
There was a problem hiding this comment.
Added get_value which is this[index] for now.
Good point about non-primitives, I think I'll need to consider that a bit though. Will handle it in a future PR if that's ok!
… happens in AS definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have so many different ways of pulling out parameters from the function, and almost every single one is wrong. The "correct" way to do it tends to be extremely verbose.
This introduces common methods for correctly getting the value of a given type from the function parameters slice, and converts BitmapData to use it as an initial proof of concept.
It's still missing more useful functions like getting native object types (DisplayObject from an arg, for example), but it's already a significant improvement.