Skip to content

core: don't store the SwfMovie in ChildContainer #20784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

moulins
Copy link
Contributor

@moulins moulins commented Jun 19, 2025

We only need the movie to know whether the container is in AVM1 or AVM2 mode, so just store a boolean instead.

@moulins moulins added A-core Area: Core player, where no other category fits T-refactor Type: Refactor / Cleanup labels Jun 19, 2025
@moulins moulins force-pushed the child-container-no-movie branch from e531fb2 to 443918d Compare June 21, 2025 02:18
We only need the movie to know whether the container is in AVM1 or AVM2 mode, so
just store a boolean instead.
@Dinnerbone Dinnerbone force-pushed the child-container-no-movie branch from 443918d to 9ec7f3c Compare June 21, 2025 15:46
@Dinnerbone Dinnerbone enabled auto-merge (rebase) June 21, 2025 15:46
@Dinnerbone Dinnerbone merged commit 4cc9ba2 into ruffle-rs:master Jun 21, 2025
23 checks passed
@moulins moulins deleted the child-container-no-movie branch June 22, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core player, where no other category fits T-refactor Type: Refactor / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants