web: Don't show CORS error message for the Internet Archive

[danielhjacobs]

Not sure how I feel about this, on the one hand it's simple and helps to stop the issues saying "why does the Internet Archive have this CORS error", but on the other hand is a single hard-coded URL. It's tough to do things any other way because the Internet Archive lies about the URL it's actually fetching due to its custom fetch code that redirects all requests to itself.

[n0samu]

I remember I had a different idea for how to accomplish this without hardcoding the URL - let me try to dig it up in the next few days

[danielhjacobs]

One way I thought of just now would be:

window.location.origin === new URL((await fetch(error.swfUrl)).url).origin

On https://web.archive.org/web/20250119102449/https://www.dnai.org/, window.location.origin === new URL((await fetch("not_a_real.swf")).url).origin

Not sure I'd want to re-do a fetch just for this though.

[danielhjacobs]

Working through the logic straight through the Rust code, I guess that is this:

https://github.com/ruffle-rs/ruffle/blob/master/core/src/tag_utils.rs#L58

I guess a more accurate swfUrl would be that.

[danielhjacobs]

Last thought wasn't quite right, but it can be done by adding a new parameter for the real SWF URL that we attempt to fetch to this function:

ruffle/core/src/backend/ui.rs

Line 85 in dc22b99

fn display_root_movie_download_failed_message(&self, _invalid_swf: bool);

[danielhjacobs]

Here, that's error.url:

ruffle/core/src/loader.rs

Line 1067 in dc22b99

.display_root_movie_download_failed_message(false);

Here, it's url:

ruffle/core/src/loader.rs

Line 1076 in dc22b99

.display_root_movie_download_failed_message(true);

Here, it's spoofed_or_swf_url:

ruffle/core/src/loader.rs

Line 1098 in dc22b99

.display_root_movie_download_failed_message(true);