avm2: Move PerspectiveProjection computation to render crate #20633
+71
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookie-s
force-pushed
the
avm2-refactor-perspective-projection
branch
from
0a652d0 to
49e7ffd
Compare
Lord-McSweeney
added
A-rendering
Molisson
approved these changes
Jun 18, 2025
Dinnerbone
approved these changes
Jun 18, 2025
Dinnerbone
force-pushed
the
avm2-refactor-perspective-projection
branch
from
49e7ffd to
d64cea8
Compare
|
Thank you! will update the other PR this weekend too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #19670
Continue to #19405 ?
This PR refactors flash.geom.PerspectiveProjection computation logics from ruffle_core to ruffle_render.
We can use those later from inside ruffle_render.