Skip to content

run synchronously on process load, and restart extension host on change #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timbertson
Copy link

#12 made me think, it seems like the only way to guarantee direnv is setup before other extensions is to do it both synchronously (no promises in the initialization code) and at process startup (otherwise it depends on extension activation order).

When reloading, it actually causes the extension host to restart because again, that seems like the only reliable way to ensure the new env is applied.

Which makes for a pretty badly behaved extension in some ways (it takes effect even if it's deactivated), but I don't see much alternative if we want to guarantee it happens first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant