Cleanup of afamily/pfamily specs for Addrinfo#initialize #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like there was a lot of copy-paste in this one, often the description did not match the actual test. The descriptions have been updated to use the shortest human readable syntax, so no `Socket::` namespace and no `PF_` prefix to the name. This matches the afamily specs (or: most of them). Additionally, a few additional spaces in the descriptions have been removed.
| @@ -53,7 +53,7 @@ | |||
| @addrinfo.ip_port.should == 25 | |||
| end | |||
|
|
|||
| it "returns the Socket::UNSPEC pfamily" do | |||
| it "returns the INET6 pfamily" do | |||
There was a problem hiding this comment.
Looks good, but in most cases a test checks that a getter returns a value passed into a constructor and nothing more. So a test title may be more generic, e.g. returns pfamily. And it seems it doesn't matter what a specific value is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was a lot of copy-paste in this one, often the description did not match the actual test.
The descriptions have been updated to use the shortest human readable syntax, so no
Socket::namespace and noPF_prefix to the name. This matches the afamily specs (or: most of them).Additionally, a few additional spaces in the descriptions have been removed.