Add spec for Warning.categories #1272
Conversation
| describe "Warning.categories" do | ||
| it "returns the list of possible warning categories" do | ||
| Warning.categories.sort.should == [:deprecated, :experimental, :performance, :strict_unused_block] | ||
| end |
There was a problem hiding this comment.
Not sure if the list should be hardcoded this way. For instance the last category (:strict_unused_block) isn't documented in https://ruby-doc.org/3.4.1/Warning.html. And I can imagine that some alternative Ruby implementation may provide some additional non-standard categories.
There was a problem hiding this comment.
Right, I think it's best to check the first 3 are included like .should.include? :deprecated, and not test :strict_unused_block or prohibit other somewhat-implementation-specific categories.
There was a problem hiding this comment.
i.e. if a Ruby implementation doesn't implement the unused block warning it shouldn't list :strict_unused_block and it should still be able to pass this spec as this list is useful to let gems/users know what kind of warnings are available.
References #1265