Skip to content

Private namespace reverse stackable with hash #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2025
Merged

Private namespace reverse stackable with hash #2596

merged 2 commits into from
Aug 23, 2025

Conversation

ericproulx
Copy link
Contributor

Remove namespace_reverse_stackable_with_hash

Scope: commit 53eed5db81286fa9b55a7e8dfd818dd9c6f4be1e only.

  • Removed private helper from lib/grape/dsl/settings.rb.
  • lib/grape/endpoint.rb now handles reverse-ordered rescue handler merging internally via a private rescue_handlers method.
  • Public API and behavior are unchanged; no test updates required.

@ericproulx
within_namespace is part on our internal api and should be exposed …
79e1da7 
…publicly. Also remove `namespace_start` and `namespace_end`
@ericproulx ericproulx marked this pull request as ready for review August 21, 2025 15:23
@ericproulx ericproulx requested a review from dblock August 21, 2025 15:23
@ericproulx ericproulx force-pushed the private_namespace_reverse_stackable_with_hash branch from 53eed5d to 924953d Compare August 21, 2025 15:24
@dblock dblock merged commit f35caa0 into master Aug 23, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock