Fix how to find Numpy headers for Windows debug #165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
sloretz
reviewed
May 16, 2022
| @@ -21,6 +21,11 @@ find_package(PythonInterp 3.6 REQUIRED) | |||
|
|
|||
| find_package(python_cmake_module REQUIRED) | |||
| find_package(PythonExtra MODULE REQUIRED) | |||
| set(_PYTHON_EXECUTABLE ${PYTHON_EXECUTABLE}) | |||
| if(WIN32 AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug") | |||
| set(PYTHON_EXECUTABLE ${PYTHON_EXECUTABLE_DEBUG}) | |||
There was a problem hiding this comment.
I'd guess setting Python3_EXECUTABLE to PYTHON_EXECUTABLE_DEBUG before find_package(Python3 ...) would allow using the the debug version of NumPY on Windows
https://cmake.org/cmake/help/latest/module/FindPython3.html#artifacts-specification
There was a problem hiding this comment.
There was a problem hiding this comment.
That's exactly what I wanted to do, but I didn't do it correctly.
|
I will also fix this in #164, as managin two PRs is making things more complicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was introduced in #160.
Example issue: https://ci.ros2.org/view/nightly/job/nightly_win_deb/2357/console.
I'm honestly guessing, worst case I will restore the logic to find Numpy headers using before #160.