rosidl_cli: Add type description support (backport #857) #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add type description support to rosidl_cli Signed-off-by: Francisco Rossi <[email protected]> * Fix typing annotation Signed-off-by: Francisco Rossi <[email protected]> * Please flake8, mypy Signed-off-by: Michel Hidalgo <[email protected]> * Please flake8 take 2 Signed-off-by: Michel Hidalgo <[email protected]> --------- Signed-off-by: Francisco Rossi <[email protected]> Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Michel Hidalgo <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit c9a3084)
There was a problem hiding this comment.
@hidmic kilted backport is straight-forward. can you approve this?
|
Pulls: #866
|
|
I do not think https://ci.ros2.org/job/ci_linux-rhel/3054/testReport/ros2param.ros2param.test/test_verb_load/test_verb_load/ is related to this PR, it fails during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for type description generation in
rosidl_cli. It introduces a new hash command to generate type descriptions. It also ensures they are always present as part of thegeneratecommand even if the user doesn't provide them.Addresses #808
Recommended Review Order
I recommend starting with the new
hashgenerator inrosidl_cli/rosidl_cli/command/hash, which utilizes the extension defined inrosidl_generator_type_description/rosidl_generator_type_description/cli.py, and then progressing to the other changes.Notes
rosidl, such asrosidl_pythonandrosidl_typesupport.This is an automatic backport of pull request #857 done by [Mergify](https://mergify.com).