Add an ament_cmake_gtest dependency to rosidl_runtime_c. #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was found while testing out a fix to colcon-core which will reduce the scope of test_depend. Regardless, this package actually does depend on ament_cmake_gtest so the dependency should be there. Signed-off-by: Chris Lalancette <[email protected]>
|
@ros-pull-request-builder retest this please |
|
Pulls: #865
|
fujitatomoya
approved these changes
May 8, 2025
cottsay
approved these changes
May 8, 2025
mjcarroll
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found while testing out a fix to colcon-core which will reduce the scope of test_depend. Regardless, this package actually does depend on ament_cmake_gtest so the dependency should be there.
This is related to colcon/colcon-core#693 . Once approved, this should likely be backported to at least Kilted, and probably also Jazzy and Humble. @cottsay FYI