[jazzy] Add cli option compression-threads-priority (backport #1768) #1778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
emersonknapp and
james-rms
and removed request for
a team
MichaelOrlov
changed the title
|
Note: There are no API/ABI breaking changes. Only ABI breaking changes in test, but is is ok since we don't guarantee API/ABI compatibility for tests. |
MichaelOrlov
approved these changes
Aug 9, 2024
MichaelOrlov
force-pushed
the
mergify/bp/jazzy/pr-1768
branch
from
299a7ac to
b880ffb
Compare
* Add cli option compression-threads-priority Signed-off-by: Roman Sokolkov <[email protected]> * Fix CI issues Signed-off-by: Roman Sokolkov <[email protected]> * Add timeout for the test_priority_propagated_into_compression_thread Signed-off-by: Michael Orlov <[email protected]> * Update help section and doxygen comments for thread priority parameters Signed-off-by: Michael Orlov <[email protected]> * Use integer type for compression threads priority default value in tests - Rationale: To test the same behavior as in the writer factory class Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Roman Sokolkov <[email protected]> Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Michael Orlov <[email protected]> (cherry picked from commit 25c3e1c)
MichaelOrlov
force-pushed
the
mergify/bp/jazzy/pr-1768
branch
from
b880ffb to
72ea3bb
Compare
|
Rebased on top latest Jazzy to get fixes for CI failures. |
|
Pulls: #1778
|
|
@ros-pull-request-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--compression-threads-priorityCLI parameter for theros2 bag recordcommand to be able to set up compression threads priority.This is an automatic backport of pull request Add cli option compression-threads-priority #1768 done by Mergify.