add QoS option to ros2service/ros2action echo commands. (backport #1036) #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add QoS option to ros2service/ros2action echo commands. Signed-off-by: Tomoya Fujita <[email protected]> * pass all optional qos parameters to configure final QoS setting. Signed-off-by: Tomoya Fujita <[email protected]> * add ros2topic exec_depend to ros2action. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 9aec897)
fujitatomoya
approved these changes
May 29, 2025
|
Pulls: #1038
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1023
Is this user-facing behavior change?
No, QoS arguments are optional, and default QoS configuration is consistent with before.
Did you use Generative AI?
No
Additional Information
N.A
This is an automatic backport of pull request #1036 done by Mergify.