-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Indicate correct branches to checkout to build CycloneDDS from source #5678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@christophebedard would it be possible for you to review this MR? as you proposed this change in the original issue |
Signed-off-by: jncfa <[email protected]>
christophebedard
requested changes
May 27, 2025
source/Installation/RMW-Implementations/DDS-Implementations/Working-with-Eclipse-CycloneDDS.rst
Outdated
Show resolved
Hide resolved
source/Installation/RMW-Implementations/DDS-Implementations/Working-with-Eclipse-CycloneDDS.rst
Outdated
Show resolved
Hide resolved
source/Installation/RMW-Implementations/DDS-Implementations/Working-with-Eclipse-CycloneDDS.rst
Outdated
Show resolved
Hide resolved
…rking-with-Eclipse-CycloneDDS.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: José Faria <[email protected]>
…rking-with-Eclipse-CycloneDDS.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: José Faria <[email protected]>
Signed-off-by: jncfa <[email protected]>
Signed-off-by: jncfa <[email protected]>
source/Installation/RMW-Implementations/DDS-Implementations/Working-with-Eclipse-CycloneDDS.rst
Outdated
Show resolved
Hide resolved
…rking-with-Eclipse-CycloneDDS.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: José Faria <[email protected]>
Signed-off-by: jncfa <[email protected]>
christophebedard
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating!
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
…#5678) Signed-off-by: jncfa <[email protected]> (cherry picked from commit 6987641)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
…#5678) Signed-off-by: jncfa <[email protected]> (cherry picked from commit 6987641)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2025
…#5678) Signed-off-by: jncfa <[email protected]> (cherry picked from commit 6987641)
This was referenced May 27, 2025
christophebedard
pushed a commit
that referenced
this pull request
May 28, 2025
…#5678) (#5685) (cherry picked from commit 6987641) Signed-off-by: jncfa <[email protected]> Co-authored-by: José Faria <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
May 28, 2025
…#5678) (#5686) (cherry picked from commit 6987641) Signed-off-by: jncfa <[email protected]> Co-authored-by: José Faria <[email protected]>
christophebedard
pushed a commit
that referenced
this pull request
May 28, 2025
…#5678) (#5687) (cherry picked from commit 6987641) Signed-off-by: jncfa <[email protected]> Co-authored-by: José Faria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a minor description on how to determine the correct versions to checkout to build CycloneDDS from source.
I also added a minor script which will automatically fetch the correct branch version for Cyclone DDS.
Fixes #5601
Did you use Generative AI?
No
Additional Information