Skip to content

Indicate correct branches to checkout to build CycloneDDS from source #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025

Conversation

jncfa
Copy link
Contributor

@jncfa jncfa commented May 27, 2025

Description

Adds a minor description on how to determine the correct versions to checkout to build CycloneDDS from source.

I also added a minor script which will automatically fetch the correct branch version for Cyclone DDS.

Fixes #5601

Did you use Generative AI?

No

Additional Information

@jncfa
Copy link
Contributor Author

jncfa commented May 27, 2025

@christophebedard would it be possible for you to review this MR? as you proposed this change in the original issue

jncfa and others added 4 commits May 27, 2025 23:59
…rking-with-Eclipse-CycloneDDS.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: José Faria <[email protected]>
…rking-with-Eclipse-CycloneDDS.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: José Faria <[email protected]>
jncfa and others added 2 commits May 28, 2025 00:47
…rking-with-Eclipse-CycloneDDS.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: José Faria <[email protected]>
Signed-off-by: jncfa <[email protected]>
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label May 27, 2025
@christophebedard christophebedard merged commit 6987641 into ros2:rolling May 27, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request May 27, 2025
mergify bot pushed a commit that referenced this pull request May 27, 2025
mergify bot pushed a commit that referenced this pull request May 27, 2025
christophebedard pushed a commit that referenced this pull request May 28, 2025
…#5678) (#5685)

(cherry picked from commit 6987641)

Signed-off-by: jncfa <[email protected]>
Co-authored-by: José Faria <[email protected]>
christophebedard pushed a commit that referenced this pull request May 28, 2025
…#5678) (#5686)

(cherry picked from commit 6987641)

Signed-off-by: jncfa <[email protected]>
Co-authored-by: José Faria <[email protected]>
christophebedard pushed a commit that referenced this pull request May 28, 2025
…#5678) (#5687)

(cherry picked from commit 6987641)

Signed-off-by: jncfa <[email protected]>
Co-authored-by: José Faria <[email protected]>
@jncfa jncfa deleted the 5601-issue branch May 28, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Unable to build CycloneDDS from source
2 participants